DOC Updated plot_date to NumPy/SciPy style #7033
Conversation
| @@ -1408,59 +1408,66 @@ def plot(self, *args, **kwargs): | |||
| def plot_date(self, x, y, fmt='o', tz=None, xdate=True, ydate=False, | |||
| **kwargs): | |||
| """ | |||
| Plot with data with dates. | |||
| A plot with data that contains dates. | |||
There was a problem hiding this comment.
These tabs need to be replaced with the correct number of spaces.
|
It appears you have not set the config for your git client. All your commits are attributed to "Your Name [email protected]", which is probably not what you want. |
| See Also | ||
| -------- | ||
| mod : matplotlib.dates for helper functions | ||
| func : matplotlib.dates.date2num |
There was a problem hiding this comment.
There is a strange indentation here.
In addition, we need to revert back to the old syntax: :func:~matplotlib.dates.date2num for proper formatting.
|
Hi Michael & Klara, The code currently has a mixture of tabs and space, due to gedit not being configured correctly. I can drop by at some point today to help you fix that. Thanks, |
| Similar to the :func:`~matplotlib.pyplot.plot` command, except | ||
| A plot with data that contains dates. | ||
|
|
||
| Similar to the :func:~matplotlib.pyplot.plot command, except |
There was a problem hiding this comment.
The backticks should not have been removed here.
|
Please remember to correct the name and committer on the first commit. |
92d6a88 to
d1e7037
Compare
|
@QuLogic FYI, we did it, but it requires rebasing and some quite complex operations. I don't think that should be a requirement for contributing to matplotlib (in addition, some people may want to stay anonymous). |
|
@klaragerlei There is still a couple of problems: I can help you with those during a break or the tutors consulting hours tonight if you'd like. |
|
That would be great @NelleV , thank you!
|
| ydate=False, **kwargs) | ||
|
|
||
| A plot with data that contains dates. | ||
|
|
There was a problem hiding this comment.
There is still some whitespace on this line.
|
It appears that you were able to take care of the rebasing? Just a small note that your name appears differently in some of the commits. CI isn't happy right now, but it is raising a cryptic error. We will have to try a local build to figure out what is wrong. |
| Other Parameters | ||
| ---------------- | ||
| kwargs : class : matplotlib.lines.Line2D | ||
| properties : %(Line2D)s |
There was a problem hiding this comment.
Line2D gets expanded into several parameter listings; it should be on its own line. (And likely needs to be updated to match this formatting.)
8c3cea8 to
e0b8239
Compare
|
Thanks a lot! This is looks great:
|
|
Are you okay with some commits using your GitHub username and not your real name like the rest of them? Also, all but the second-last commit use the email of @clairesophie but the name is @klaragerlei. Please double-check that you will be attributed correctly. |
|
This PR has been done as pair coding, so it is going to be hard to attribute it properly. |
|
@QuLogic I think I managed to fix the double account problem, and it's all correct now, thank you for noticing. |
|
@klaragerlei Thanks! |
DOC Updated plot_date to NumPy/SciPy style
|
backported to v2.x as 2ddc50e |
|
There were still two emails with the same name used for different commits; are they the same person? |
|
Yes, both of them are mine, sorry, one of them is a university email On 14 September 2016 at 22:51, Elliott Sales de Andrade <
|
Hello,
We updated the documentation of plot_date to NumPy/SciPy style.
Thanks,
Michael, Klara
@NelleV