This looks good! Thanks for the patch.

@tacaswell This is ready for review (and for merge).

There seems to be formatting problems in the PR I did not pick up in my first review.

line 1611 W291 trailing whitespace
line 1621 W291 trailing whitespace
line 1623 W291 trailing whitespace
line 1631 W293 blank line contains whitespace

It appears you have not set the config for your git client. All your commits are attributed to "Your Name [email protected]", which is probably not what you want.

I fixed the trailing whitespaces, but I can't figure out why there are still failing tests.
Regarding the git configuration: I would leave it this way for now and do a better job next time.

Hi @JuliaSprenger
The failing test is not related to your PR.
Thanks for the contribution! Here is how it looks:

The name on the first commit needs to be fixed. If you are not comfortable with rebasing before hand, we need to remember to do so before merging.

I am not super concerned about semi-bogus names on commits. We have not been strict about that in the past and we do not have any need for strict contribution audits.

It's fine if it used something unique from the computer or similar, but this is a generic name from git. It cannot be fixed by .mailmap.

I changed the name and email for the first commit using rebase. I hope nothing else changed, but it seems to work.

Thanks!

backported to v2.x as 873d393

Thanks @JuliaSprenger!

Hopefully we will hear from you again soon.