Thanks to visit codestin.com
Credit goes to github.com

Skip to content

TST: Restore broken test_use14corefonts #7094

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 12, 2016

Conversation

Kojoley
Copy link
Member

@Kojoley Kojoley commented Sep 12, 2016

History:

History:

 - c0fcab4 - disabled on travis
 - f4adec7 - commented out
 - ff227d3 - enabled, but chopped
@jenshnielsen
Copy link
Member

👍 IMHO it's a bug that the previous code did not raise an error. It's basically comparing a valid pdf to a empty image as far as I can see

@Kojoley
Copy link
Member Author

Kojoley commented Sep 12, 2016

The weak place is for fignum, baseline in zip(plt.get_fignums(), self._baseline_images):. zip shrinks lists to the size of the smallest. I am working on a refactor of image_comparison decorator and the issue come up on several tests, but this one was the most surprising.

@jenshnielsen
Copy link
Member

Thanks @Kojoley good to know

@jenshnielsen jenshnielsen merged commit 4f559a9 into matplotlib:master Sep 12, 2016
@QuLogic QuLogic added this to the 2.1 (next point release) milestone Sep 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants