Qt close #716
Merged
Qt close #716
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I can confirm that this fixes the bug. |
|
I just ran into this qt close issue, and I can also confirm that this fix works. |
|
I notice that this was applied to the maintenance branch, but, as far as I can tell, not to master. I'm just curious: what's the typical update procedure for backported fixes (err, I guess it's the opposite of a backport). |
|
Typically we merge v1.1.x into master periodically to bring all of these fixes in master. If it's a bug that applies to the maintenance branch, we'd like the pull request on the branch, because our standard workflow is to periodically merge these fixes into master, |
|
@jdh2358 That makes sense. Thanks for clarifying. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented Pierre's suggested fix for the dreaded qt close event bug. Tested on ubuntu with pyqt 4.8.5. This fixes #711