Thanks to visit codestin.com
Credit goes to github.com

Skip to content

ENH Improving the contribution guidelines #7236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Nov 2, 2016
Merged

ENH Improving the contribution guidelines #7236

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
d00c927
ENH contributing guidelines are now all in one place
NelleV Oct 8, 2016
419ce52
ENH Improved contributing documentation
NelleV Oct 8, 2016
0b9974c
DOC remove transformation.rst and hide license doc
NelleV Oct 8, 2016
085844a
FIX typo
NelleV Oct 8, 2016
9799d66
DOC improved organization and titles
NelleV Oct 8, 2016
9547bc7
ENH better styling for notes, warnings and see also section
NelleV Oct 11, 2016
5a9f988
DOC Better crosslinking of dev references
NelleV Oct 11, 2016
c97d6ac
DOC better title
NelleV Oct 11, 2016
54e0c9c
DOC no more addition to pyplot
NelleV Oct 12, 2016
76a5ab2
DOC fixes to the reviewer's guide
NelleV Oct 12, 2016
19603a5
DOC added easy-fix and new-contributor-friendly tags
NelleV Oct 12, 2016
388a4a0
DOC better styling for topic sections
NelleV Oct 12, 2016
4d8963f
DOC Transformations are now documented in the API
NelleV Oct 29, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
DOC better title
  • Loading branch information
@NelleV
NelleV committed Oct 29, 2016
commit c97d6ac0cb4fa47d9855060417537c0bd24f90d9
11 changes: 5 additions & 6 deletions doc/devel/contributing.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,10 +67,9 @@ environment <http://conda.pydata.org/docs/using/envs.html>`_

.. note::

**Additional dependencies for testing**: nose_ (version 1.0 or later),
`mock <http://www.voidspace.org.uk/python/mock/>`_ (if python < 3.3),
`Ghostscript <http://pages.cs.wisc.edu/~ghost/>`_, `Inkscape
<http://inkscape.org>`_
**Additional dependencies for testing**: nose_ (version 1.0 or later), `mock
<http://www.voidspace.org.uk/python/mock/>`_ (if python < 3.3), `Ghostscript
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This link might be outdated.

<http://pages.cs.wisc.edu/~ghost/>`_, `Inkscape <http://inkscape.org>`_
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ghostscript link might be outdated as well. http -> https on the Inkscape link.


.. note:: To make sure the tests run locally:

Expand All @@ -87,7 +86,6 @@ environment <http://conda.pydata.org/docs/using/envs.html>`_ is recommended.
.. seealso::

* :ref:`testing`
* :ref:`using-git`


Contributing code
Expand All @@ -106,7 +104,7 @@ then submit a "pull request" (PR):
2. Fork the `project repository
<https://github.com/matplotlib/matplotlib>`__: click on the 'Fork' button
near the top of the page. This creates a copy of the code under your
account scikit-learnon the GitHub server.
account on the GitHub server.

3. Clone this copy to your local disk::

Expand Down Expand Up @@ -137,6 +135,7 @@ visibility.

* `Git documentation <https://git-scm.com/documentation>`_
* :ref:`development-workflow`.
* :ref:`using-git`

Contributing pull requests
--------------------------
Expand Down
6 changes: 3 additions & 3 deletions doc/devel/gitwash/development_workflow.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
.. _development-workflow:

====================
Development workflow
====================
=========================
Git Development workflow
=========================
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like an extra =?


You've discovered a bug or something else you want to change
in matplotlib_ .. |emdash| excellent!
Expand Down