DOC: Add missing API change docs for 1.5.3 #7254
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QuLogic
reviewed
Oct 12, 2016
|
|
||
| Prior to 1.5.3 kwargs passed to `~matplotlib.Axes.plot` were handled | ||
| in two parts -- user supplied kwargs and default kwargs generated | ||
| `~matplotlib.Axes.plot` (such as the cycled styles). The two |
There was a problem hiding this comment.
Seems like there's a word missing between this line and the above one.
| `~matplotlib.Axes.plot` (such as the cycled styles). The two | ||
| dictionaries are now merged and passed into | ||
| `~matplotlib.lines.Line2D.__init__` all at once instead of applying the | ||
| user supplied kwargs via a bulk update after the artist has been created. |
There was a problem hiding this comment.
"via a bulk update" seems extraneous.
|
|
||
| This causes ``None`` passed as ``plot(..., marker=None)`` to now 'do | ||
| the default' thing rather than to result in no marker. This is only | ||
| an issue if the user explicitly passes ``None`` and has changed the |
There was a problem hiding this comment.
"the user" seems like a different PoV than the rest of this document, though it's not perfectly consistent anyway...
2e5b8c2 to
7f55b9e
Compare
|
@QuLogic basicly re-wrote it. |
NelleV
approved these changes
Oct 12, 2016
QuLogic
reviewed
Oct 12, 2016
| in two parts -- default kwargs generated internal to | ||
| `~matplotlib.Axes.plot` (such as the cycled styles) and user supplied | ||
| kwargs. The internally generated kwargs were passed to the | ||
| `~matplotlib.lines.Line2D.__init__` and the user kwargs were passed to |
There was a problem hiding this comment.
That would generate as "The internally generated kwargs were passed to the __init__ and ...", right? It seems like using the full name would be a good idea here (no ~.)
| of ``ax.plot(..., marker=None)`` changed from 'no markers' to 'default markers | ||
| from rcparams'. | ||
|
|
||
| This is change in only evident if ``mpl.rcParams['lines.marker']`` has a value |
There was a problem hiding this comment.
"This is change in" -> "This change is", I think.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #7218