Fix image watermark example where image was hidden by axes (#7265) #7273
Conversation
|
Hi @AndersonDaniel There's a lot of things that are confusing in matplotlib, whether you are advanced or a beginner. A lot of the choices where made a very long time ago and the context was different 10 - 15 years ago than it is now. I was wondering if you had a little more courage and if you could also add a bit of documentation to this example, using a docstring at the top of the file to be sphinx-gallery compatible. It's just a docstring with a title and a small text description, with a blank line between the title and the description. |
|
Note: this closes #7265 |
|
@NelleV Thanks for the quick response! |
|
Thanks! That looks good! |
|
@AndersonDaniel Thanks and congratulations on your first mpl contribution 🎉 Did you find this issue via the 'new-contributor-friendly' label? |
DOC: Fix image watermark example where image was hidden by axes close #7265
|
backported to v2.x as 421327d |
|
Thanks @tacaswell ! Yes, I found it through both that label and "Difficulty: Easy" |
Hi!
I'm new to matplotlib and would be happy to contribute if I can.
Did as @anntzer suggested in the issue (only with
zorder=3like in the Text class) and of course it worked:I was also wondering why FigureImage has
zorder=0by default, doesn't that mean images drawn on figures will always be hidden by the axes (unless thezorderargument is explicitly set)?Another thing that could be a bit confusing is that the example passes the
zorderkeyword argument tofigimageeven though it's only intercepted by the constructor of Artist class (and thus doesn't appear infigimage's docs)... Then again maybe it's only confusing for new people :)Thanks!