Remove deprecated stuff schedule for removal. #7290
Conversation
4085cbd to
badb300
Compare
|
Can you document the removals in api_changes? |
badb300 to
db35561
Compare
|
done |
| class and its subclasses. The ``toggle_axisline`` method has been removed from | ||
| the ``mpl_toolkits.axes_grid1.mpl_axes.Axes`` class. | ||
|
|
||
| Support for setting an ``Axes``' aspect to ``normal"`` has been removed, in |
There was a problem hiding this comment.
No, it's supposed to render as
an Axes' aspect
(well I hope that's correct in English :-))
There was a problem hiding this comment.
wow… OK.
Yeah, I think that's proper english, but you know… french people and english…
There was a problem hiding this comment.
There is, however, a missing double-quote on "normal".
db35561 to
f234dad
Compare
|
fixed |
| Removal of deprecated features | ||
| ------------------------------ | ||
|
|
||
| The ``matplotlib.backends.qt_compat`` module has been removed. |
There was a problem hiding this comment.
Isn't it qt4_compat that was removed, not qt_compat?
f234dad to
ad6e561
Compare
|
Has some overlap with #4128 which seems to need another rebase. |
|
Merge one of them first and then the author of the other can do the rebase? |
|
I (maybe biasedly) have a preference for mine as it links back to the issue/commit where things were deprecated. |
|
That's completely fine, can it be merged first then? |
|
I did. |
ad6e561 to
ce615e8
Compare
|
Rebased; merged the changelog into yours. |
| @@ -1727,53 +1716,6 @@ def onRemove(self, ev): | |||
| break | |||
| h = parent | |||
|
|
|||
| def onHilite(self, ev): | |||
There was a problem hiding this comment.
This is missing a removal note.
| @@ -37,43 +34,6 @@ def _tick_only(ax, bottom_on, left_on): | |||
| ax.axis["left"].toggle(ticklabels=left_off, label=left_off) | |||
|
|
|||
|
|
|||
| class Colorbar(mcolorbar.Colorbar): | |||
| def _config_axes_deprecated(self, X, Y): | |||
There was a problem hiding this comment.
This is a subclass of mpl_toolkits.axes_grid1.colorbar.Colorbar (not matplotlib.Colorbar) that adds a single private method that is not even used anywhere else.
ce615e8 to
347ebef
Compare
| Deprecated methods | ||
| ------------------ | ||
|
|
||
| The ``set_graylevel`` and ``onHilite`` methods have been removed from the |
There was a problem hiding this comment.
onHilit is from FigureCanvasBase
There was a problem hiding this comment.
Sorry, being sloppy today... fixed.
Everything removed here had either a deprecation warning indicating removal scheduled in 1.6, or deprecation since at least two minor releases. (The exception, `axes_grid1.axes_grid.Colorbar`, is completely equivalent to the standard Colorbar -- it only adds a private, unused method.) Also adjusted an example that used a deprecated module.
347ebef to
867d6f1
Compare
Everything removed here had either a deprecation warning indicating
removal scheduled in 1.6, or deprecation since at least two minor
releases.
(The exception,
axes_grid1.axes_grid.Colorbar, is completelyequivalent to the standard Colorbar -- it only adds a private, unused
method.)
Also adjusted an example that used a deprecated module.