MAINT finance module is deprecated #7295
Conversation
| @@ -2,7 +2,7 @@ | |||
| A collection of functions for collecting, analyzing and plotting | |||
| financial data. User contributions welcome! | |||
|
|
|||
| This module is deprecated in 1.4 and will be moved to `mpl_toolkits` | |||
| This module is deprecated in 2.0 and will be moved to `mpl_toolkits` | |||
There was a problem hiding this comment.
"and has been moved to it's own project" ?
|
Looks good modulo minor word smithnig. Who ever merges, please remember to backport to v2.x |
|
Backported to v2.x via 83292f5. |
MAINT finance module is deprecated
|
@NelleV Actually this interferes somewhat awkwardly with the fact that IPython still imports pylab (#7186 (comment), fixed as of IPython 5.2). Now you get the deprecation warning when running |
|
Maybe the deprecation warning needs to be inside each function in the module, instead of at the module level? |
|
we could just wrap the import in a warning context and snarf the warning? IPython merged my PR to remove most of the pylab imports ipython/ipython#9998 |
|
I think @tacaswell's solution is the best. |
|
I think having the warning at least at module level is important, as some people sometimes import stuff from our modules (totally unrelated to our code) which is going to break as well. (That used to be a reason not to remove unused imports at the top of some of our modules). I could also be very aggressive and add deprecation warnings to all the functions of the module. That's extremely easy to do with our deprecated decorator. I'll look at ipython's issue with our deprecation warning. |
Here is a deprecation for the finance module.
Supersedes #7071
We should probably make a call for contributor out.