Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Changed Examples for Pep8 Compliance #7298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 18, 2016
Merged

Conversation

sirlittle
Copy link
Contributor

Changed demo_parasite_axes2.py and demo_floating_axis.py to add pep8 compliance as well a docstring for the sphinx_gallarey.

Copy link
Member

@NelleV NelleV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the small typo, this looks good.

👍

onto one single plot. Notice how in this example, par1 and
par2 are both calling twinx meaning both are tied directly to
the x-axis. From there, each of those two axis can behave
seperately from the current x-axis as well as the other
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there is a type here: seperately -> separately.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't quite understand. The previous sentence says that both are tied to the x-axis, but this sentence says they can behave separately.

@NelleV NelleV changed the title Changed Examples for Pep8 Compliance [MRG+1] Changed Examples for Pep8 Compliance Oct 17, 2016
@tacaswell
Copy link
Member

Looks like there is some trailing whitespace left...


The following code demonstrates how to put a floating
polar curve within a rectangular box. In order to get
a better sense of polar curbes, please look at
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

curbes -> curves

"""
Parasite Axis Demo

The following code is an example of of a parasite axis.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duplicate "of".

onto one single plot. Notice how in this example, par1 and
par2 are both calling twinx meaning both are tied directly to
the x-axis. From there, each of those two axis can behave
seperately from the current x-axis as well as the other
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't quite understand. The previous sentence says that both are tied to the x-axis, but this sentence says they can behave separately.

@@ -1,30 +1,35 @@
"""
An experimental support for curvilinear grid.
Axis Within Rectangular Frame
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@NelleV Do we want to capitalize every word in the sphinx-gallery docstring title, or only the first word? I've been doing only the first word like in the example here. I know this seems nitpicky, but a style mismatch will stand out in the sphinx gallery view. :P

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First word sounds better.
Sorry @sirlittle : do you mind quickly updating this?

@QuLogic QuLogic changed the title [MRG+1] Changed Examples for Pep8 Compliance Changed Examples for Pep8 Compliance Oct 18, 2016
@QuLogic QuLogic added this to the 2.0.1 (next bug fix release) milestone Oct 18, 2016
@QuLogic QuLogic merged commit e0fe1f9 into matplotlib:master Oct 18, 2016
@QuLogic
Copy link
Member

QuLogic commented Oct 18, 2016

Oops, missed the whitespace stuff, fixed in 023caec.

@QuLogic
Copy link
Member

QuLogic commented Oct 18, 2016

Backported to v2.x as 4833e41 and 0da61ef.

QuLogic added a commit to QuLogic/matplotlib that referenced this pull request Oct 18, 2016
Changed Examples for Pep8 Compliance
@QuLogic QuLogic modified the milestones: 2.0.1 (next bug fix release), 2.0 (style change major release) Dec 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants