Thanks to visit codestin.com
Credit goes to github.com

Skip to content

CI: test on 3.6-dev branch #7307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 21, 2016
Merged

CI: test on 3.6-dev branch #7307

merged 2 commits into from
Oct 21, 2016

Conversation

tacaswell
Copy link
Member

@tacaswell tacaswell commented Oct 19, 2016

nightly currently points at 3.7-dev which is broken during Travis's
portion of setting up the test.

Require the 3.6 build to pass (as it will be out soon).

travis docs: https://docs.travis-ci.com/user/languages/python/#Choosing-Python-versions-to-test-against

Require the 3.6 build to pass (as it will be out soon).
@Kojoley
Copy link
Member

Kojoley commented Oct 19, 2016

Maybe just add 3.6-dev without removing nightly?

P.S. I can open a PR for fixing nightly build, but do not know what branch to target then.

@tacaswell tacaswell changed the title CI: test on 3.6-dev branch rather than nightly CI: test on 3.6-dev branch Oct 19, 2016
@tacaswell
Copy link
Member Author

@Kojoley I was in the middle of doing that as you left that comment.

It seems that I was looking at an old run of travis as nightly seems to be working again.

@Kojoley
Copy link
Member

Kojoley commented Oct 19, 2016

Ah, yeah, it is working now again. The problem that previously made the build fail was the lack of virtualenv package on travis nightly, it seems that travis team have solved it.

@Kojoley
Copy link
Member

Kojoley commented Oct 19, 2016

Still failing. I have opened #7308.

@tacaswell
Copy link
Member Author

I wonder if it varies worker-to-worker? https://travis-ci.org/matplotlib/matplotlib/jobs/168745358 passed.

@Kojoley
Copy link
Member

Kojoley commented Oct 19, 2016

I though the build you are pointing is working too, but actually it failed to create virtualenv (expand # Install into our own pristine virtualenv entry to see it).

@QuLogic
Copy link
Member

QuLogic commented Oct 19, 2016

This probably needs a rebase now.

@Kojoley
Copy link
Member

Kojoley commented Oct 20, 2016

This probably needs a rebase now.

This PR targets v2.x, while #7308 was merged into master so either #7308 needs remilestoning and a backport or this PR needs retargeting.

@tacaswell
Copy link
Member Author

We should backport #7308 and I will rebase this again.

The goal of this PR was to make sure 2.0 does not have any surprises with 3.6

@tacaswell
Copy link
Member Author

On second thought, I'll just add a commit with the one line. The backport isn't clean due to the travis files diverging.

@tacaswell tacaswell modified the milestones: 2.0.1 (next bug fix release), 2.0 (style change major release) Oct 20, 2016
@Kojoley Kojoley merged commit 0f7dbfc into matplotlib:v2.x Oct 21, 2016
@tacaswell tacaswell deleted the ci_py36 branch October 21, 2016 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants