-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
DOC MEP12 - converted lines, bars and markers to SG/MEP12 compatible #7327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@@ -1,4 +1,3 @@ | |||
from __future__ import print_function, division | |||
""" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure why this file is here.
I think(?) sphinx-gallery requires both a title and some non-empty "content", right? Would it be better to ask them (or write a PR ourselves) that drops the requirement for the content (generating a page with just a title and a plot) and/or special cases the case of the a single-line docstring to use it as both title and content? I feel that docstrings of the form
or
are mostly line noise... (As a side note I think that the correct capitalization is matplotlib, not Matplotlib -- see home page, for example.) |
Not sure that discussion was ever concluded. |
sphinx-gallery is very unlikely to drop that requirement considering it is a very good way to enforce good documentation and meaningful examples. I'll ask one of the maintainer if this is an option but don't hold your breath. for the matplotlib versus Matplotlib, considering these are lines that were there before me, I'd rather not have to modify them. I am going for the minimal change possible on all examples to precisely make the PR mergeable quickly and without discussion. |
I agree that the requirement is, in theory, good. In practice, repeating the title in the description is somewhat defeating its goal... Sorry for the capitalization noise :) |
@anntzer I might create a PR fixing the capitalization as that's a quick easy fix. |
'plot_fill.py', | ||
'plot_fill_features.py', | ||
'plot_line_dash_control.py', | ||
'plot_line_styles_reference.py', | ||
'scatter_with_legend.py' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should scatter_with_legend
be renamed as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Eventually, when we move to sphinx-gallery, it'll have to.
I am a bit concerned about renaming examples breaking people's bookmarks. Why not backport example-only changes as far back as we can? That way the next time we re-generate the docs (ex on a micro release) the updated examples will be built. |
If we migrate to sphinx-gallery, this will not be an option: examples are split between the one that produce a plot and no plot (and I hope soon, a video). This can be done right at the end, specially considering @efiring mentioned cleaning up and removing some of our examples (we have around 450 examples right now…). |
(I can easily revert this change). |
@tacaswell eh… I hadn't seen/understood your comments on the milestone. Documentation is as important as code. It needs to be checked, reviewed and maintained. IMO, backporting documentation and examples changes should not be taken lightly. Instead of backporting to 2.0, I think we should be thinking about 2.1. |
All of our examples should be producing a plot and the name pattern sphinx-gallery looks for is configurable (ex https://github.com/NSLS-II/docs/blob/master/source/conf.py#L68 from my day-job). The criteria for backports onto the RC should be critical or low risk. Doc changes (particularly to examples or rst prose) can not break anyone's code so are zero-risk. I don't see what is wrong with merging maintenance branches up into the master branch. |
On 3 January 2017 at 04:08, Thomas A Caswell ***@***.***> wrote:
All of our examples should be producing a plot and the name pattern
sphinx-gallery looks for is configurable (ex https://github.com/NSLS-II/
docs/blob/master/source/conf.py#L68 from my day-job).
I'd estimate about 75% of our examples produce plots.
The criteria for backports onto the RC should be critical or low risk. Doc
changes (particularly to examples or rst prose) can not break anyone's code
so are zero-risk.
That's up to you to decide what should be backported. But the vast majority
of elements that have been backported are neither low risk nor critical.
There are a bunch of PR that fix bugs that have been in matplotlib for ages
that are currently tagged 2.x
I don't see what is wrong with merging maintenance branches up into the
master branch.
—
… You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#7327 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AALR3ifV0qd4LBROuM_35EpQplU5w3rzks5rObuogaJpZM4KdoNH>
.
|
I've reverted the change in filenames, but it will be impossible to migrate to sphinx-gallery without a way to distinguish examples that produces plots to those that don't from the filename. |
Current coverage is 62.09% (diff: 100%)@@ master #7327 diff @@
==========================================
Files 174 174
Lines 56050 56050
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 34807 34807
Misses 21243 21243
Partials 0 0
|
I am closing this PR. |
This is ready to be merged. |
DOC MEP12 - converted lines, bars and markers to SG/MEP12 compatible
Backported |
Thanks @NelleV, these are great improvements! I'm really looking forward to helping more with migrating to sphinx-gallery |
Minor modification to have the lines, bars and markers section Sphinx-gallery compatible.
See #7206