MAINT Matplotlib -> matplotlib #7387

NelleV · 2016-11-03T02:59:26Z

For consistency, renaming all instances in the documentation of Matplotlib into matplotlib.
Somehow, I did not feel comfortable sedding the code…

attn @anntzer

NelleV · 2016-11-03T02:59:44Z

CHANGELOG

@@ -203,7 +203,7 @@

 2013-04-25 Changed all instances of:

-           from matplotlib import MatplotlibDeprecationWarning as mplDeprecation
+           from matplotlib import matplotlibDeprecationWarning as mplDeprecation


anntzer · 2016-11-03T03:52:49Z

sedding \bmatplotlib\b would have helped? :)
The discussion at #6535 (diff) suggests that opinions are split on capitalization... I prefer lowercase but most importantly let's decide once and for all on one choice.

NelleV · 2016-11-03T03:57:21Z

I remember having this discussion around a glass of very good whisky in 2013 in an AT&T center…
I personally prefer Matplotlib but have been told at the time that matplotlib was the way to go.

tacaswell · 2016-11-03T13:17:12Z

doc/devel/MEP/MEP12.rst

@@ -196,6 +196,6 @@ navigate the gallery. Thus, tags are complementary to this reorganization.

 .. [1] http://github.com/matplotlib/matplotlib/pull/714
 .. [2] http://github.com/matplotlib/matplotlib/issues/524
-.. [3] http://matplotlib.1069221.n5.nabble.com/Matplotlib-gallery-td762.html#a33379091


does this break the link?

No it doesn't - urls are not case-sensitive.

It automatically redirects you to uppercased variant because this part of url is just a topic of the thread

tacaswell · 2016-11-03T13:18:14Z

doc/devel/release_guide.rst

@@ -152,7 +152,7 @@ Then copy the build products into your local checkout of the
 `~/matplotlib.github.com`::

  cp -r build/html/* ~/matplotlib.github.com
-  cp build/latex/Matplotlib.pdf ~/matplotlib.github.com


probably should leave this + where were it gets generated as capital (to not break peoples bookmarks / scripts).

tacaswell · 2016-11-03T13:18:52Z

doc/faq/howto_faq.rst

 ===============

 If you want to refer to matplotlib in a publication, you can use
-"Matplotlib: A 2D Graphics Environment" by J. D. Hunter In Computing


This should match the capitalization of the actual paper

tacaswell · 2016-11-03T13:19:42Z

doc/resources/index.rst

@@ -13,19 +13,19 @@
  <https://www.packtpub.com/big-data-and-business-intelligence/mastering-matplotlib>`_
  by Duncan M. McGreggor

-* `Interactive Applications Using Matplotlib


These should match the titles of the books.

tacaswell · 2016-11-03T13:21:13Z

doc/users/github_stats.rst

@@ -720,17 +720,17 @@ Issues (605):
 * :ghissue:`6970`: quiver problems when angles is an array of values rather than 'uv' or 'xy'
 * :ghissue:`6966`: No Windows wheel available on PyPI for new version of matplotlib (1.5.2)
 * :ghissue:`6721`: Font cache building of matplotlib blocks requests made to HTTPd
-* :ghissue:`6844`: scatter edgecolor is broken in Matplotlib 2.0.0b3


this file is going to get thrashed as it is auto-generated :/

Unrelated to this issue, but can you share the scripts of the auto-generation?

https://github.com/matplotlib/matplotlib/blob/master/tools/github_stats.py

Kojoley · 2016-11-03T17:46:41Z

doc/_templates/citing.html

@@ -11,12 +11,12 @@
 <pre>
 @Article{Hunter:2007,
  Author    = {Hunter, J. D.},
-  Title     = {Matplotlib: A 2D graphics environment},
+  Title     = {matplotlib: A 2D graphics environment},


Again, a book title.

NelleV · 2016-11-08T23:10:17Z

I fixed the issues.
There is still I think a debate whether we should capitalize matploltib. I personnally don't care either way, but we should be consistent across our documentation.
Just let me now whether I have to replace all instances of matplotlib with Matplotlib.

NelleV · 2016-11-29T23:14:50Z

I don't have a strong opinion about this PR but considering the changes tackled here, it either needs to be merged or to be closed. If I don't receive any feedback in the next couple of days, I will close it.

efiring · 2016-11-30T03:38:44Z

I vote to close it. I think that forcing lower case at the start of a sentence looks terrible. Either always upper case, or letting the case go up and down like that of a normal noun, is fine with me. I don't even care whether it is consistent.

anntzer · 2016-11-30T04:36:58Z

Somewhat in favor of getting it consistent, but not feeling strongly about it.

QuLogic · 2016-12-07T02:58:42Z

As with @efiring, slight preference for capitalization; our GitHub organization is Matplotlib Developers, not matplotlib Developers, after all... (That's not really much of an argument, of course.)

WeatherGod · 2016-12-08T14:58:34Z

My vote is to treat it as a proper noun, except in the case of referring to the package name as `matplotlib`. Furthermore, I think `mpl` should always be lower-case and never used at the start of a sentence (and really, it should be avoided). I haven't decided yet about what to do for pyplot and pylab. They really shouldn't be proper nouns, so I wouldn't go as far as I would with Matplotlib with respect to capitalization, but they would look weird if they start a sentence lower-cased.

…

On Tue, Dec 6, 2016 at 9:58 PM, Elliott Sales de Andrade < ***@***.***> wrote: As with @efiring <https://github.com/efiring>, slight preference for capitalization; our GitHub organization *is* Matplotlib Developers, not matplotlib Developers, after all... (That's not really much of an argument, of course.) — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#7387 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AARy-JH2LakjmglHI_-LUL-6xwq1nz44ks5rFiDjgaJpZM4Kn9rD> .

NelleV commented Nov 3, 2016

View reviewed changes

MAINT Matplotlib -> matplotlib

e8f3cbd

tacaswell reviewed Nov 3, 2016

View reviewed changes

Kojoley reviewed Nov 3, 2016

View reviewed changes

FIX document title should be consistent

744d028

NelleV changed the title ~~MAINT Matplotlib -> matplotlib~~ [MRG] MAINT Matplotlib -> matplotlib Nov 10, 2016

NelleV closed this Dec 16, 2016

QuLogic changed the title ~~[MRG] MAINT Matplotlib -> matplotlib~~ MAINT Matplotlib -> matplotlib Apr 30, 2017

Uh oh!

MAINT Matplotlib -> matplotlib #7387

MAINT Matplotlib -> matplotlib #7387

Uh oh!

Conversation

NelleV commented Nov 3, 2016

Uh oh!

Choose a reason for hiding this comment

Uh oh!

anntzer commented Nov 3, 2016

Uh oh!

NelleV commented Nov 3, 2016

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

NelleV commented Nov 8, 2016

Uh oh!

NelleV commented Nov 29, 2016

Uh oh!

efiring commented Nov 30, 2016

Uh oh!

anntzer commented Nov 30, 2016

Uh oh!

QuLogic commented Dec 7, 2016

Uh oh!

WeatherGod commented Dec 8, 2016 via email

Uh oh!

Uh oh!