Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Numpydoc for backends #7397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 26, 2016
Merged

Numpydoc for backends #7397

merged 4 commits into from
Nov 26, 2016

Conversation

QuLogic
Copy link
Member

@QuLogic QuLogic commented Nov 3, 2016

I've had this lying around for a while, but it's incomplete insofar as I didn't have a chance to add types to everything. I don't really want it to go completely to waste though.

Apparently, I had a lot of free time at the beginning of the year and did the same for a lot of other files. The trouble is, that was with the expectation of switching to napoleon, so there are a few corrections that need to be made to work with our current build (which you can see in the second commit here.) Should I post those up somewhere (and maybe tag with Need contributor)?

@QuLogic
Copy link
Member Author

QuLogic commented Nov 14, 2016

I've added types to all the backend files I've already touched. The descriptions are not perfect, but several of the backends do not appear in the documentation, presumably because they cannot all be loaded at the same time or the dependencies are not available. I tried adding them, but it broke the builds, so that's something for another time.

@QuLogic QuLogic changed the title Numpydoc for backends [MRG] Numpydoc for backends Nov 14, 2016
@NelleV NelleV changed the title [MRG] Numpydoc for backends [MRG+1] Numpydoc for backends Nov 21, 2016

* `interval`: The time between timer events in
milliseconds. Default is 1000 ms.
single_shot: bool
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here and below, my understanding from @NelleV is that the colon must be surrounded by spaces.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Grrr, thought I got all of those.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, else it won't render properly. I wouldn't hold this PR for this thought. It's been around way too long.

Copy link
Member

@efiring efiring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine based on a quick scan, apart from the two spots where spaces probably need to be inserted.

The previous changes were intended for napoleon, but that has yet to be
merged. NumPyDoc supports a few less section names, and requires them to
be in a specific order. Also, a little bit of whitespace change needed
to render stuff properly.
@QuLogic
Copy link
Member Author

QuLogic commented Nov 26, 2016

Huh, that was way more outdated than I thought, but fortunately no conflicts. Rebased and addressed the last two comments.

@efiring efiring changed the title [MRG+1] Numpydoc for backends Numpydoc for backends Nov 26, 2016
@efiring efiring merged commit 6a56f69 into matplotlib:master Nov 26, 2016
@QuLogic QuLogic deleted the doc-backends branch November 26, 2016 04:22
@QuLogic QuLogic added this to the 2.1 (next point release) milestone Nov 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants