Make hatch colour an rcParam. #7415
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You could add a test based on a simplified version of the example in #7166, so that the legend would be tested. |
|
I added a test based on @dopplershift's shortened test in #7166, which I think basically covers the path hit by legends. Interestingly, it isn't broken in PDF or SVG because they determine the colour in some other way somehow. In fact, there's even a test |
|
Hmm, just realized the PDF is broken when using |
|
On closer inspection, that may be a bug in evince, as it appears fine in pdf.js, inkscape and convert/imagemagick. |
dopplershift
approved these changes
Nov 7, 2016
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This turned out easier than I expected because I just had to follow the same work as #6198. As with
hatch.linewidth, there is no API to do this, only the rcParam.Not sure if I should add an explicit test, some other tests kind of implicitly test this stuff (as seen from the updated images.)
Fixes #7166. Also, partially implements #7059.