Minor cleanup of hist(). #7481
Merged
Minor cleanup of hist(). #7481
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| else: | ||
| boffset = 0.0 | ||
| stacked = False | ||
| boffset = -0.5 * dr * totwidth * (1 - 1 / nx) |
There was a problem hiding this comment.
Doesn't this introduce the possibility of divide-by-zero?
There was a problem hiding this comment.
l.6284 also divides by nx, so if nx is 0, we already to a divide-by-zero.
There was a problem hiding this comment.
if nx is zero, then there is no data so other things are confused as well.
There was a problem hiding this comment.
It seems to me that due to l. 6176-6181 (and above), the case nx == 0 should never occur: the case where the input is empty is preprocessed to have a length of 1.
# Massage 'x' for processing.
if input_empty:
x = np.array([[]])
else:
x = _normalize_input(x, 'x')
nx = len(x) # number of datasets
NelleV
approved these changes
Nov 18, 2016
|
LGTM |
|
As much as touching |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly style, use
clip, get rid of a redundant conditional.