Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Silence deprecation warning when importing finance in pylab #7524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 29, 2016

Conversation

efiring
Copy link
Member

@efiring efiring commented Nov 28, 2016

The discussion is in #7295.

There is still a problem, though: the deprecation message says to switch to the toolkit. How is the user supposed to know how to do that? It's not in the mpl_toolkits part of the distribution.

@efiring efiring added this to the 2.0 (style change major release) milestone Nov 28, 2016
@NelleV
Copy link
Member

NelleV commented Nov 28, 2016

I don't really understand the problem: there are many toolkits that are not part of the distribution (cmocean for example).

@efiring
Copy link
Member Author

efiring commented Nov 28, 2016

Yes, but they are not toolkits that are being removed from mpl. The deprecation gives no clue as to where the new toolkit is, or even what it is called. Is it available anywhere other than via github? pip search cmocean shows that it exists under that name, and can be installed; pip search finance yields a long list, but I don't see anything that might be our finance toolkit.
Don't you think a user of finance.py might be puzzled upon seeing that deprecation message?

@NelleV
Copy link
Member

NelleV commented Nov 28, 2016

I'd indeed add the mpl_toolkits finance to pypi if it hasn't been done, to do a proper release. I can take care of this.
We've done something similar in slkearn, when we removed the hmm from sklearn and released it as a separate unmaintained project. There was not much confusion, but we did do a proper release and probably added a note somewhere to explain how to pip install it.

@NelleV NelleV changed the title Silence deprecation warning when importing finance in pylab [MRG+1] Silence deprecation warning when importing finance in pylab Nov 28, 2016
@tacaswell tacaswell merged commit 5203df6 into matplotlib:v2.x Nov 29, 2016
@QuLogic QuLogic changed the title [MRG+1] Silence deprecation warning when importing finance in pylab Silence deprecation warning when importing finance in pylab Nov 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants