DOC added new dependencies for 2.0 #7540
Conversation
| @@ -265,6 +268,9 @@ Optional dependencies | |||
| required, but can make installation go more smoothly if the libraries and | |||
| headers are not in the expected locations. | |||
|
|
|||
| `subprocess32 <https://pypi.python.org/pypi/subprocess32/>`_ | |||
There was a problem hiding this comment.
Is this really optional? It is probably worth adding a python 2 only dependancies section for this and functools23
There was a problem hiding this comment.
It's really optional.
I can add a section python 2 only.
There was a problem hiding this comment.
Sigh, I even merged the PR where that went in....
|
I've added a new sections for python 2 only requirements. I've also removed six as a library shipped with matplotlib from the documentation, as this is obviously not the case anymore. |
|
Thanks for cleaning the the remnants of when we vendored |
| Required for compatibility if running on versions of Python before | ||
| Python 3.2. | ||
|
|
||
| `six <https://pypi.python.org/pypi/six>`_ |
There was a problem hiding this comment.
six is required for both (because we import it all over the place).
|
I've moved back six where it belongs. |
|
I tweaked the wording a bit (as subprocess32 is not actually required). |
|
Thanks! (It looks good to me and I think you should totally merge this - no conflict of interest at all :) ) |
|
Probably should wait for travis to catch up (rst is harsh and capricious). |
|
Is it normal that only the travis-ci tests show up on that PR? |
|
For some time now, Appveyor has not been running on 2.x, only on master. |
|
Then I guess this PR is ready to be merged :) |
|
I added a commit using the web editor interface; I've never tried that before. |
Added the missing dependencies from our installation instructions.
closes #6580