Eventplot edgecases #7602
Closed
Eventplot edgecases #7602
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tacaswell
reviewed
Dec 10, 2016
| if len(linewidths) == 0: | ||
| lineoffsets = [None] | ||
| linewidths = [None] | ||
| if len(linestyles) == 0: |
There was a problem hiding this comment.
I understand why to do this for symmetry, but this is a odd special case. Why would you pass in an empty list to get the default behavior?
There was a problem hiding this comment.
I guess one could also ask why one would want to pass an empty list to get the default for any of the earlier parameters... (unless there's a compelling reason, we should get rid of that behavior :-))
|
I have no plans to work on this further, so going to close. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7560
matplotlib.collections.EventCollection doesn't like being handed
Noneforlineoffsets,linelengths, orlinestyles, so if a zero-length array is provided I've set it to just pass the default values.Possibly in the future matplotlib.collections.EventCollection wants to be able to accept
Nonefor these kwargs?