Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Massive doc-style work, focused upon axes.py. #765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Mar 17, 2012

Conversation

WeatherGod
Copy link
Member

Also added entry in index.html for 'subplots'.

The style changes are not exhaustive, but I tried to find the most visible ones. Also fixed a lot of common :class: references (Colormap is in colors.py, not cm.py!). Should eventually convert a lot of the argument descriptions into ReST tables.

Also added entry in index.html for 'subplots'.
@mdboom
Copy link
Member

mdboom commented Mar 15, 2012

I can't say that I looked at every change in great detail, but these all look like good and reasonable improvements. Thanks for going some not-so-fun grunt work ;)

Turn *y* autoscaling on (*True*), off (*False*; default),
or leave unchanged (*None*)

Note, the *bottom* (formerly *ymin*) value may be greater than
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would the ``.. note::` directive render things nicer here, or is that too loud?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought about that, but I think it would be too "loud" because of the code examples that would have to go inside the note box as well.

@pelson
Copy link
Member

pelson commented Mar 16, 2012

I have gone through this pull and it looks good to me.

@pelson
Copy link
Member

pelson commented Mar 16, 2012

I have gone through this pull and it looks good to me.

I should add that I have only reviewed the changes made, not identified changes not made. So there may well still be examples of code blocks not being lead with a ::, doctstrings with inconsistent formatting etc., but some progress is better than none :-) .

@pelson
Copy link
Member

pelson commented Mar 16, 2012

Given axes.py's documentation is so long, it would be great if the sidebar would float down as you scroll.

I know the sphinx "basic" theme has a stickysidebar option (http://sphinx.pocoo.org/theming.html), but unfortunately it doesn't exist on the sphinxdoc theme.

@WeatherGod
Copy link
Member Author

A stickysidebar idea is actually not a bad one. I have been so focused on the content of the documentation that I have not really looked into what else is possible with sphinx. I will take a gander.

@WeatherGod
Copy link
Member Author

Probably the other more important change that is needed is a overhaul of the documentation guide page. This is in major need of rework to not only provide important style guides to developers, but also possibly a cheat-sheet to contributors to make documenting easier by knowing exactly what is expected where.

@@ -83,7 +81,7 @@
for 'dots' or 'inches', resizing does not change the arrows.


*angles*: ['uv' | 'xy' | array]
*angles*: [ 'uv' | 'xy' | array]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove leading space on this line.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leading space? You mean the space I added there to match with just about all the other docstrings? Note that I just noticed that I also should add a space after "array" on that line as well.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, nevermind, I see what you mean.

@efiring
Copy link
Member

efiring commented Mar 17, 2012

@WeatherGod, it would be good to get this committed ASAP, so with or without the two indentation fixes I noted above, I suggest you go ahead and merge this.

@WeatherGod
Copy link
Member Author

Ok, this is a huge step forward. I am gonna go ahead and get this merged in.

WeatherGod added a commit that referenced this pull request Mar 17, 2012
Massive doc-style work, focused upon axes.py.
@WeatherGod WeatherGod merged commit cbef0cc into matplotlib:v1.1.x Mar 17, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants