-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Interactive setting of savefig rcParams (Qt only). #7696
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👍 in principle. Is there a way to work this into the UI other than another modal dialog box? How much can we hack on the filepicker? |
would this second window always pop up? I would find that incredibly
annoying. I would rather have something that would show up with the
file-chooser dialog as advance settings or something.
…On Thu, Dec 29, 2016 at 2:07 PM, Thomas A Caswell ***@***.***> wrote:
👍 in principle.
Is there a way to work this into the UI other than another modal dialog
box? How much can we hack on the filepicker?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#7696 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AARy-AARlpdkPEbBICeWAtEvxXbVm6SWks5rNATegaJpZM4LXRDX>
.
|
A quick googling suggests that it is possible to embed a QFileDialog within, say, a QHBoxLayout so that one has a standard filepicker on the left and the options panel on the right. It would require quite a bit more effort to implement though. Right now the second window always pops up but you can just through it, and it is not different from the behavior of, say, Inkscape when saving to a format where options are available, and it's not that intrusive either. |
173a197
to
3652e4a
Compare
Upon further searching, I now believe that it is not possible to embed a Qt file dialog into a larger widget, unless we choose to not use the native file dialog (see difference at https://kb.froglogic.com/display/KB/Automating+native+or+Qt+%28file%29+dialogs+in+Qt+applications#AutomatingnativeorQt%28file%29dialogsinQtapplications-DialogsinQtapplications). (The reason being that a native file dialog can be anything and Qt cannot know how to embed it.) In my opinion, using the native dialog is much preferrable from a UI POV, so I'd rather keep this PR as it is (except for a rebase). |
3652e4a
to
dbb34b1
Compare
I put together an alternative implementation, which uses an additional menu for setting the options. The toolbutton menu is easy enough to discover (so that the feature actually gets used...) without being as conspicuous as an additional tool button. Not sure how this would interact with MEP22 though. |
53f9c7c
to
09979bd
Compare
Maybe too late for this, but why don't use a canvas and the widgets that we have, this way, we can reuse for other backends |
I think a native window is just much nicer. See also #8683. |
Yes I agree that native widgets are much nicer. |
I'm not a fan of adding more Qt-only features, unless we decide that's really the direction the project wants to go in. |
f863e69
to
17d5cac
Compare
An additional window pops after selecting the filename to allow setting of savefig-related rcParams. For simplicity and consistency, the "ps.usedistiller" rcParam is now normalized to `None` when not set.
17d5cac
to
2129eb0
Compare
@anntzer I'll close this as not likely to move forward, but feel free to reopen if you want to re-pursue |
An additional window pops after selecting the filename to allow setting
of savefig-related rcParams.
For simplicity and consistency, the "ps.usedistiller" rcParam is now
normalized to
None
when not set.Closes #7352.