Add rcsetup_api.rst, fix typo for rcsetup.cycler #7732
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dopplershift
requested changes
Jan 3, 2017
| @@ -0,0 +1,12 @@ | |||
| ***** | |||
There was a problem hiding this comment.
The length of the **** needs to match that of rcsetup; that's causing a warning from sphinx.
WeatherGod
requested changes
Jan 3, 2017
| cyl(label1=itr1[, label2=itr2[, ...]]) | ||
| cyler(arg) | ||
| cyler(label, itr) | ||
| cyler(label1=itr1[, label2=itr2[, ...]]) |
There was a problem hiding this comment.
still has a typo. cyl was the original name, but then we decided it was ok to collide with the cycler from the cycler package.
There was a problem hiding this comment.
Hm, can you clarify what you mean by still having a typo? What's the exact?
There was a problem hiding this comment.
cyler should be cycler
|
Ugh...bozo mistakes. I looked at |
WeatherGod
approved these changes
Jan 4, 2017
|
The human brain is a weird place
…On Tue, Jan 3, 2017 at 8:33 PM, Pete Huang ***@***.***> wrote:
Ugh...bozo mistakes. I looked at cyler for like 15 minutes and still
couldn't figure it out
|
Current coverage is 62.12% (diff: 100%)@@ master #7732 diff @@
==========================================
Files 174 174
Lines 56028 56028
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 34805 34805
Misses 21223 21223
Partials 0 0
|
WeatherGod
added a commit
that referenced
this pull request
Jan 4, 2017
Add rcsetup_api.rst, fix typo for rcsetup.cycler
|
backported to v2.x branch via 3b48809 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #7223