Update qhull to 2015.2 #7747
Merged
Update qhull to 2015.2 #7747
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Restarted the 2 failed tests (look transient to me). I see no reason not to do this. |
|
@ianthomas23 Can you add a note to whats_new or api_changes (which ever you think is better) noting we bumped the vendored version. |
tacaswell
approved these changes
Jan 5, 2017
Current coverage is 62.12% (diff: 100%)@@ master #7747 diff @@
==========================================
Files 174 174
Lines 56028 56028
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 34805 34805
Misses 21223 21223
Partials 0 0
|
596a131 to
9a658c0
Compare
|
@tacaswell I've added an entry to api_changes, and squashed that commit. |
NelleV
approved these changes
Jan 13, 2017
|
Thanks @ianthomas23 ! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the qhull source code that we ship with matplotlib to be the latest version, 2015.2. There is no change in functionality.
I was going to change it to use the new reentrant version of qhull which is somewhat more thread safe. However, in trying this I unearthed a bug in debian-based distributions which ship the reentrant header files but not the shared library (libqhull_r.so). I have reported this to debian many weeks ago (https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=841168), but there hasn't even been an acknowledgement of the bug yet never mind a fix. Shipping mpl using the reentrant version whilst this bug still exists would result in lots of failed installs, so I have stuck to the original non-reentrant version and will write another PR when debian fix the bug.
Assuming this passes the tests and everyone is happy with it, it will close issue #6791.