Thanks to visit codestin.com
Credit goes to github.com

Skip to content

MAINT: Deterministic SVG and PDF tests #7748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jan 21, 2017
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix documentation mistakes
  • Loading branch information
jkseppan committed Jan 20, 2017
commit ec941b49f91223a0ac1a954dc52c1a71fda18d4c
8 changes: 4 additions & 4 deletions doc/users/whats_new/reproducible_ps_pdf.rst
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ The ``SOURCE_DATE_EPOCH`` environment variable can now be used to set
the timestamp value in the PS and PDF outputs. See
https://reproducible-builds.org/specs/source-date-epoch/

Alternatively, calling ``savefig`` with ``metadata={creationDate=None}``
Alternatively, calling ``savefig`` with ``metadata={'creationDate': None}``
will omit the timestamp altogether.

The reproducibility of the output from the PS and PDF backends has so
Expand All @@ -17,10 +17,10 @@ versions need to be kept constant for reproducibility, and they may
add sources of nondeterminism outside the control of matplotlib.

For SVG output, the ``svg.hashsalt`` rc parameter has been added in an
earlier release. In can be used to change some random id values in the
earlier release. It can be used to change some random id values in the
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand the following sentence:
"It can be used to change some random id values in the output to be deterministic, at the cost that including multiple such SVG files in one document can lead to collisions."
Isn't there an grammar problem?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll try to rephrase.

output to be deterministic, at the cost that including multiple such
svg files in one document can lead to collisions.
SVG files in one document can lead to collisions.

These features are now enabled in the tests for the pdf and svg
These features are now enabled in the tests for the PDF and SVG
backends, so most test output files (but not all of them) are now
deterministic.