DOC: Changes to screenshots plots. #7821
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* removed ugly pie chart * changed fontsize of labels in scatter plot * changed y-range in sine plot to work around bounding box problem.
|
I think having the images generated is a great idea, and this can be done by adding them to the gallery and linking them from the gallery. You can look in scikit-learn how it is done there, thought sphinx-gallery generates more plots than our current gallery system, so it needs to be adapted a bit: (This can be found here: https://github.com/scikit-learn/scikit-learn/blob/master/doc/themes/scikit-learn/layout.html) |
|
After discussing with @tacaswell, we're going to merge this as is and backport ASAP to 2.x in preparation for the release. |
Merged
|
Backported to |
|
@NelleV This probably the best solution. I took a look at the gallery extension and I did not understand how to generate plots without having a rst-page. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before:
After:
@NelleV As stated in #7740, I don't have strong preferences concerning
doc/make.py. If it helps with your future work, I can restore the original behavior of utilizing static images for the front page plots (If you prefer to do that yourself in this pull request, feel free).