Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Convert mlab tests to pytest #7883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 22, 2017
Merged

Convert mlab tests to pytest #7883

merged 4 commits into from
Jan 22, 2017

Conversation

QuLogic
Copy link
Member

@QuLogic QuLogic commented Jan 20, 2017

This is the single largest file with changes, simply because it's just so big anyway. But that means it can only get simpler from here. I have a feeling that some of these tests could be parametrized, but it was large enough without such changes.

The first commit, while the largest (just barely), is also the automated one, so it's probably safe.

@QuLogic QuLogic added this to the 2.1 (next point release) milestone Jan 20, 2017
Copy link
Member

@NelleV NelleV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would much rather just changing the import. This migration is making the tests much harder to read.

It looks good.

@NelleV NelleV changed the title Convert mlab tests to pytest [MRG+1] Convert mlab tests to pytest Jan 20, 2017
AppVeyor doesn't install pytest, so the nose build fails with this one.
@phobson phobson merged commit 21c8157 into matplotlib:master Jan 22, 2017
@phobson phobson changed the title [MRG+1] Convert mlab tests to pytest Convert mlab tests to pytest Jan 22, 2017
@QuLogic QuLogic deleted the pytest-mlab branch January 22, 2017 02:59
@rcomer rcomer mentioned this pull request Oct 16, 2022
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants