DOC MEP12: pie/polar and color examples + style sheets fix #7900
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QuLogic
reviewed
Jan 20, 2017
| @@ -1,4 +1,8 @@ | |||
| """ | |||
| ====================================== | |||
| Colors in the default property cycle | |||
| ====================================== | |||
There was a problem hiding this comment.
Should be the same length as text.
There was a problem hiding this comment.
It actually can be longer, but not shorter than the text, so this will compile fine.
| @@ -81,7 +85,10 @@ def plot_color_gradients(cmap_category, cmap_list): | |||
| for ax in axes: | |||
| ax.set_axis_off() | |||
|
|
|||
| return axes | |||
There was a problem hiding this comment.
It's not used for anything; why bother?
| import matplotlib.pyplot as plt | ||
| from matplotlib import colors as mcolors | ||
|
|
||
|
|
There was a problem hiding this comment.
Don't remove; two blank lines after imports.
063ec43 to
5dc27fb
Compare
QuLogic
reviewed
Jan 21, 2017
| @@ -13,7 +17,7 @@ | |||
| thick = lwbase * 3 | |||
|
|
|||
| fig, axs = plt.subplots(nrows=2, ncols=2, sharex=True, sharey=True) | |||
| for icol in range(2): | |||
| for icol in np.arange(2): | |||
5dc27fb to
cfb368a
Compare
Current coverage is 62.17% (diff: 100%)@@ master #7900 diff @@
==========================================
Files 174 174
Lines 56121 56121
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 34893 34896 +3
+ Misses 21228 21225 -3
Partials 0 0
|
QuLogic
approved these changes
Jan 21, 2017
cfb368a to
eecad0e
Compare
|
Thanks @naoyak |
|
Backported to |
QuLogic
pushed a commit
that referenced
this pull request
Jan 30, 2017
DOC MEP12: pie/polar and color examples + style sheets fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: #7206
Also some small changes from #7890 which didn't make it in before merge