-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Clean up quiver docstring + add simple quiver example #7913
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Current coverage is 62.08% (diff: 100%)@@ master #7913 diff @@
==========================================
Files 174 175 +1
Lines 56121 56132 +11
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
- Hits 34896 34847 -49
- Misses 21225 21285 +60
Partials 0 0
|
I really wished we did not add more examples to the gallery. If you've added an example, can you remove one? |
I've removed the simple quiver demo that was in the other examples file, but left in the more complicated ones. |
@@ -37,7 +23,6 @@ | |||
plt.axis([-1, 7, -1, 7]) | |||
plt.title('scales with plot width, not view') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can these be at the top of the plot code? I tend to scan for the title code and then expect the rest of the code underneath it to make the new figure.
@@ -72,7 +55,6 @@ | |||
plt.axis([-1, 7, -1, 7]) | |||
plt.title("triangular head; scale with x view; black edges") | |||
|
|||
# 6 | |||
plt.figure() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
agree with @NelleV that there are a lot of examples here; it's kinda overwhelming and is there a reasonable way for it to be pared down? Specially since this is a pylab example and so all these features are (or should be) documented the OO way?
@@ -0,0 +1,14 @@ | |||
'''A simple example of a quiver plot, with a quiverkey.''' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no comma needed
Closing and reopening for appveyor. |
Okay, that's got rid of two examples that only really changed arrow styles, and I've simplified the remaining 3 examples. |
@@ -0,0 +1,14 @@ | |||
'''A simple example of a quiver plot with a quiverkey.''' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a sphinx-gallery compatible title?
"""
===========
Short title
===========
small description
"""
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😃 the new simplified examples. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
[MRG+2] Clean up quiver docstring + add simple quiver example
Made into a numpydoc-string, and clarified a few things. I have also added a simple quiver and quiverkey example, since the current quiver example runs to 6 figures.