Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Clean up quiver docstring + add simple quiver example #7913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Jan 29, 2017

Conversation

dstansby
Copy link
Member

@dstansby dstansby commented Jan 21, 2017

Made into a numpydoc-string, and clarified a few things. I have also added a simple quiver and quiverkey example, since the current quiver example runs to 6 figures.

@phobson phobson added this to the 2.0.1 (next bug fix release) milestone Jan 22, 2017
@codecov-io
Copy link

codecov-io commented Jan 22, 2017

Current coverage is 62.08% (diff: 100%)

Merging #7913 into master will decrease coverage by 0.09%

@@             master      #7913   diff @@
==========================================
  Files           174        175     +1   
  Lines         56121      56132    +11   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
- Hits          34896      34847    -49   
- Misses        21225      21285    +60   
  Partials          0          0          

Powered by Codecov. Last update 1be56c8...fdffaf6

@dstansby dstansby changed the title Clean up quiver docstring Clean up quiver docstring + add simple quiver example Jan 22, 2017
@NelleV
Copy link
Member

NelleV commented Jan 22, 2017

I really wished we did not add more examples to the gallery. If you've added an example, can you remove one?

@dstansby
Copy link
Member Author

I've removed the simple quiver demo that was in the other examples file, but left in the more complicated ones.

@@ -37,7 +23,6 @@
plt.axis([-1, 7, -1, 7])
plt.title('scales with plot width, not view')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can these be at the top of the plot code? I tend to scan for the title code and then expect the rest of the code underneath it to make the new figure.

@@ -72,7 +55,6 @@
plt.axis([-1, 7, -1, 7])
plt.title("triangular head; scale with x view; black edges")

# 6
plt.figure()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agree with @NelleV that there are a lot of examples here; it's kinda overwhelming and is there a reasonable way for it to be pared down? Specially since this is a pylab example and so all these features are (or should be) documented the OO way?

@@ -0,0 +1,14 @@
'''A simple example of a quiver plot, with a quiverkey.'''
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no comma needed

@NelleV
Copy link
Member

NelleV commented Jan 27, 2017

Closing and reopening for appveyor.

@NelleV NelleV closed this Jan 27, 2017
@NelleV NelleV reopened this Jan 27, 2017
@dstansby
Copy link
Member Author

Okay, that's got rid of two examples that only really changed arrow styles, and I've simplified the remaining 3 examples.

@@ -0,0 +1,14 @@
'''A simple example of a quiver plot with a quiverkey.'''
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a sphinx-gallery compatible title?

"""
===========
Short title
===========

small description
"""

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@story645 story645 changed the title Clean up quiver docstring + add simple quiver example [MRG + 1] Clean up quiver docstring + add simple quiver example Jan 29, 2017
Copy link
Member

@story645 story645 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😃 the new simplified examples. Thanks!

Copy link
Member

@NelleV NelleV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@NelleV NelleV changed the title [MRG + 1] Clean up quiver docstring + add simple quiver example [MRG+2] Clean up quiver docstring + add simple quiver example Jan 29, 2017
@story645 story645 merged commit 430e308 into matplotlib:master Jan 29, 2017
@story645 story645 changed the title [MRG+2] Clean up quiver docstring + add simple quiver example Clean up quiver docstring + add simple quiver example Jan 29, 2017
story645 added a commit to story645/matplotlib that referenced this pull request Jan 29, 2017
[MRG+2] Clean up quiver docstring + add simple quiver example
story645 added a commit that referenced this pull request Jan 29, 2017
QuLogic added a commit that referenced this pull request Jan 29, 2017
@QuLogic
Copy link
Member

QuLogic commented Jan 29, 2017

Backported by @story645 to v2.0.0-doc as dfb4e9e.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants