Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix StixSans mapping bug #7945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 15, 2017
Merged

fix StixSans mapping bug #7945

merged 1 commit into from
Dec 15, 2017

Conversation

severalfew
Copy link

Use default map 'rm' if given font class is not found,
Fix for issue #7939

@settheory
fix StixSans mapping bug
d858133 
use default map 'rm' if given font class is not found
@NelleV
Copy link
Member

NelleV commented Jan 25, 2017

Hi @settheory
Thanks for the patch. The patch looks good, but is missing a regression tests. Can you add one?
Thanks,

@severalfew
Copy link
Author

Hi @NelleV
What do you mean by regression test? This is my first pull request. Thanks for the help!
The following checks are queued automatically:
continuous-integration/appveyor/pr — Waiting for AppVeyor build to complete
continuous-integration/travis-ci/pr — The Travis CI build is in progress

@NelleV
Copy link
Member

NelleV commented Jan 25, 2017

@settheory It is a unit tests written when a bug is found to make sure the patch fixes the bug and to make sure we don't reinclude this bug in the future (thus the name regression tests).

@tacaswell tacaswell added this to the 2.0.1 (next bug fix release) milestone Jan 25, 2017
@QuLogic QuLogic modified the milestones: 2.0.1 (next bug fix release), 2.0.2 (next bug fix release) May 3, 2017
@tacaswell tacaswell modified the milestones: 2.1 (next point release), 2.0.3 (next bug fix release) Jul 11, 2017
@tacaswell
Copy link
Member

@settheory Are you interested in working on this further?

@tacaswell tacaswell modified the milestones: 2.1 (next point release), 2.2 (next next feature release) Aug 29, 2017
anntzer
anntzer approved these changes Dec 15, 2017
View reviewed changes
Copy link
Contributor

@anntzer anntzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clearly fixing a logic error; it's better to merge even without a test rather than leaving the wrong behavior...

@efiring efiring merged commit 2278607 into matplotlib:master Dec 15, 2017
@anntzer anntzer mentioned this pull request Dec 15, 2017
Closed
@QuLogic QuLogic modified the milestones: needs sorting, v2.2.0 Feb 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anntzer anntzer anntzer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.2.0
Development

Successfully merging this pull request may close these issues.
8 participants
@severalfew @NelleV @tacaswell @anntzer @efiring @QuLogic @dstansby @settheory