File closing #795
Closed
File closing #795
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…osing open file handles
| length1 += len(data) | ||
| self.currentstream.write(data) | ||
| fontfile.close() | ||
| with open(filename, 'rb') as fontfile: |
There was a problem hiding this comment.
Michael, this and every other "with" statement will fail in python2.4. Since 1.1.x is out last python2.4 compatible branch, we can't have any of these.
|
Fixed by #798. Closing this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport to v1.1.x of this commit
4cb2aaa
It tries to be more careful about closing open file handles to prevent file handle exhaustion on Windows.