PySide backend support #80

gstorer · 2011-04-11T07:54:18Z

Hi,
I've modified the Qt backend to switch between PySide and PyQt using the same environment variable as IPython.

There are a couple of outstanding bugs in PySide that are apparent in matplotlib:
489 - temporary work around in qt.py that can be removed when PySide fixes the bug. Fixed in source.
819 - temporary work around in qt.py that can be removed when PySide fixes the bug. Default file filter isn't set.
736 - Only affects the subplot configuration tool. Fixed in PySide 1.0.1.

I also removed the 'hackish' fix for the bug in early version of PyQt 4.6.x - it could be added to qt.py if it was felt necessary.

I've added a Qt slot to the FigureManagerQT class that passes straight through to the status bar - this seemed to fix a segfault that may or may not be a bug in PySide. I haven't been able to separately reproduce it and PySide isn't really suppose to support the old style slots/signals.

I've modified formlayout to use getColor instead of getRgba as PySide does not have the later function. I also had to alias all of the Qt names used by formlayout as you can't double import things.

Regards,
Gerald.

gstorer · 2011-04-28T02:29:34Z

Updated to remove the fix for PySide bug 489 and added a work around for the PySide removal of support for old style classes.

The only outstanding bug is 819 where the default file filter can't be set.

gstorer · 2011-05-02T03:00:11Z

There are now no outstanding bugs with PySide that matplotlib exposes (that I am aware of).

mdboom · 2011-05-06T13:53:37Z

lib/matplotlib/backends/qt.py

The name of this file is problematic. It breaks the Qt3 backend (since 'qt' is the name of the PyQt library version 3 -- the backend tries to import the bindings but instead gets this file.) It's also confusing to read "from qt import ..." in the Qt4 backends and not have that refer to the main qt library.

Perhaps it should be called "qt4_compat.py" or something similar?

Good point. I just blindly copied the file from IPython but they don't support Qt3.

…classes to support PySide backend.

…classes.

gstorer · 2011-05-09T03:06:01Z

All of mdboom's comments implemented. I also changed backend_version while I was at it to be more consistent with the other backends. That is, a version string representing the GUI toolkit's version rather than something arbitrary.

leejjoon · 2011-05-09T06:34:17Z

lib/matplotlib/backends/backend_qt4agg.py

@@ -91,7 +91,7 @@ class FigureCanvasQTAgg( FigureCanvasQT, FigureCanvasAgg ):
            else:
                stringBuffer = self.renderer._renderer.tostring_argb()

-            qImage = QtGui.QImage(stringBuffer, self.renderer.width,
+            qImage = QtGui.QImage(stringBuffer, self.renderer.width, 


With ubuntu 11.4 (pyside 1.0.1 & qt4 4.7.2), I get a following exception.

TypeError: 'PySide.QtGui.QImage' called with wrong argument types:
PySide.QtGui.QImage(str, int, int, PySide.QtGui.QImage.Format)
Supported signatures:
PySide.QtGui.QImage()
PySide.QtGui.QImage(PySide.QtGui.QImage)
PySide.QtGui.QImage(PySide.QtCore.QSize, PySide.QtGui.QImage.Format)
PySide.QtGui.QImage(QString, str = None)
PySide.QtGui.QImage(int, int, PySide.QtGui.QImage.Format)
PySide.QtGui.QImage(buffer, int, int, PySide.QtGui.QImage.Format)
PySide.QtGui.QImage(buffer, int, int, int, PySide.QtGui.QImage.Format)

Converting stringBuffer to a buffer object explicitly seem to solve the problem (both pyqt and pyside works), but i'm not sure if this behavior will depend on the pyside version.

qImage = QtGui.QImage(buffer(stringBuffer), int(self.renderer.width), int(self.renderer.height),

We may need a same change at line 117.
The agg renderer has a "buffer_rgba" method but QImage does not seem to support RGBA format.

-JJ

This is a PySide bug fixed in 1.0.2 http://bugs.pyside.org/show_bug.cgi?id=489

We should probably add a version check against PySide then, since we know 1.0.2 is the minimum workable version.

Good to know that this is a pyside bug. However, using explicit buffer call does any harm to matplotib w/ pyside v1.0.2?
I could be wrong but my guess is that if we call buffer explicitly, the code will work for both v1.0.2 and v1.0.1?

Yes. Wrapping with buffer makes it work in both versions. I was under the impression that mpl wasn't in the business of fixing bugs for specific versions of on specific platforms etc. In any case, there's another bug (819, see my opening comment) that wasn't fixed until 1.0.2 (try saving a figure). There is also an outstanding bug that prevents this backend working on mac (809) that won't be fixed until 1.0.3.

I'd suggest that 1.0.3 should probably be the minimum supported version to keep things simple. In which case this can stay as is. Unless there is a good reason to want to wrap with buffer() in any case?

In my experience, mpl tries to broadly support as many versions of a library on as many platforms as feasible. I don't know if it's stated explicitly anywhere, but at least in my work environment, it is very important to support rather old and possibly buggy versions of core dependencies (e.g. GUI toolkits) for quite some time. Look at the GTK backend, for example, for a number of version-specific hacks that have been required over time. Eventually the idea is to prune that stuff out -- my own rule of thumb is to support at least as far back as whatever was in the (current release - 2) of RHEL.

In this specific case, however, with PySide being so new and cutting edge to begin with, I think it's ok to require a minimum version and not add hacks for 1.0.x which were fairly ephemeral and not widely-used releases. But the version check is important because user's should understand it's breaking because of an old version of PySide and not some other reason.

I was inclined to fix the buffer thing since pyside v1.0.1 is packaged for ubuntu, and this simple fix at least makes the backend usable. Anyhow, I agree with Michael and the current approach is okay.

Ok, that's good then.

As a side note, I was under the impression that Ubuntu was more or less the development platform for PySide. Every version of PySide is packaged for it within a few hours of release isn't it?

gstorer · 2011-05-10T08:02:39Z

I've added a version check for 1.0.3 or greater. The PySide nightly builds are on 1.0.3 (http://www.pyside.org/files/nightly/) although you're limited to Windows or something Debian based.

gstorer · 2011-05-27T01:48:46Z

PySide 1.0.3 has been released. I'll update the dev mailing list to solicit some final testing as packages become available.

ddale · 2011-06-05T12:12:25Z

Is this patch ready for final testing? It would be nice to merge in time for the next release.

gstorer · 2011-06-07T01:59:41Z

Yep. The only thing I'm really waiting on is for someone to tell me there are no show stoppers in OS X. This has been a bit tricky since there isn't a PySide 1.0.3 package for OS X yet. I've asked for it on the PySide mailing list today.

leejjoon · 2011-06-09T08:16:09Z

I don't think we have to wait until we have a bug-free PySide. I'm +1 for pulling this immediately. We may update the version check later if necessary.

leejjoon · 2011-06-09T08:22:14Z

Running this code from command line raises an exception during the exit. This only happens for "pyside". With "pyqt", it runs okay. This is not a show stopper and this can be fixed after the patch is pulled.

import matplotlib.pyplot as plt
fig= plt.figure(1)

Error in atexit._run_exitfuncs:
Traceback (most recent call last):
  File "/usr/lib/python2.6/atexit.py", line 24, in _run_exitfuncs
    func(*targs, **kargs)
  File "/home/jjlee/.virtualenvs/mpl-head/lib/python2.6/site-packages/matplotlib/_pylab_helpers.py", line 82, in destroy_all
    manager.destroy()
  File "/home/jjlee/.virtualenvs/mpl-head/lib/python2.6/site-packages/matplotlib/backends/backend_qt4.py", line 373, in destroy
    self._widgetclosed )
RuntimeError: Internal C++ object (PySide.QtGui.QMainWindow) already deleted.
Error in sys.exitfunc:
Traceback (most recent call last):
  File "/usr/lib/python2.6/atexit.py", line 24, in _run_exitfuncs
    func(*targs, **kargs)
  File "/home/jjlee/.virtualenvs/mpl-head/lib/python2.6/site-packages/matplotlib/_pylab_helpers.py", line 82, in destroy_all
    manager.destroy()
  File "/home/jjlee/.virtualenvs/mpl-head/lib/python2.6/site-packages/matplotlib/backends/backend_qt4.py", line 373, in destroy
    self._widgetclosed )
RuntimeError: Internal C++ object (PySide.QtGui.QMainWindow) already deleted.

gstorer · 2011-06-09T10:42:13Z

I actually get a error from both pyqt and pyside on exit...

gstorer · 2011-06-14T02:12:18Z

I don't know what was going on before but I can't get a runtime error at all now. This might be platform specific. I'm mostly using Windows XP at work. At any rate I think this is good enough to be pulled into master.

PySide backend support

…_generator Added the points generator.

gstorer added 6 commits April 11, 2011 15:39

Added PySide support to Qt4 backend.

f73a1c9

Merge branch 'master' of https://github.com/matplotlib/matplotlib

fcdc78f

Remove fix for PySide bug 489.

bd8658c

Fix for the removal of old-style class support from PySide.

6844901

Fix for the removal of old-style class support from PySide.

6ccb243

Remove some tabs accidentally added.

89f82f2

gstorer added 2 commits April 28, 2011 14:00

Change attribute check to use hasattr().

ecd7ffd

Remove work around for PySide bug 819. Bug was fixed in PySide 1.0.2

e13997d

mdboom reviewed May 6, 2011
View reviewed changes

gstorer added 4 commits May 9, 2011 10:40

Widget, FigureCanvasBase and NavigationToolbar2 changed to new style …

039814b

…classes to support PySide backend.

Qt compatibility library rename and backend_version fix.

aaaec76

Rename qt.py to qt4_compat.py

4e7a8fc

FigureCanvasBase, NavigationToolbar2 and widget changed to new style …

a80b001

…classes.

leejjoon reviewed May 9, 2011
View reviewed changes

Added version check for PySide >= 1.0.3.

5c963ae

Updated formlayout to include the float validator

69e8d2d

ddale added a commit that referenced this pull request Jun 16, 2011

Merge pull request #80 from gstorer/master

cf0644a

PySide backend support

ddale merged commit cf0644a into matplotlib:master Jun 16, 2011

richbwood mentioned this pull request Dec 19, 2012

test_pcolormesh hangs #1609

Closed

magnunor pushed a commit to magnunor/matplotlib that referenced this pull request Dec 5, 2013

Fixes matplotlib#80

efe250d

QuLogic modified the milestones: v1.1.0, v2.0.0 Nov 4, 2015

fariza added a commit to fariza/matplotlib that referenced this pull request Sep 22, 2016

Merge pull request matplotlib#80 from fgoudreault/restructure_dataset…

6aa72b9

…_generator Added the points generator.

Uh oh!

PySide backend support #80

PySide backend support #80

Uh oh!

Conversation

gstorer commented Apr 11, 2011

Uh oh!

gstorer commented Apr 28, 2011

Uh oh!

gstorer commented May 2, 2011

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

gstorer commented May 9, 2011

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

gstorer commented May 10, 2011

Uh oh!

gstorer commented May 27, 2011

Uh oh!

ddale commented Jun 5, 2011

Uh oh!

gstorer commented Jun 7, 2011

Uh oh!

leejjoon commented Jun 9, 2011

Uh oh!

leejjoon commented Jun 9, 2011

Uh oh!

gstorer commented Jun 9, 2011

Uh oh!

gstorer commented Jun 14, 2011

Uh oh!

Uh oh!