FIX: do not try to render empty images #8006
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not bother trying to render Images which have zero-dimension in any direction. Simply return from the `draw` method early closes matplotlib#7886
b9fec5b to
c4700bb
Compare
|
@NelleV Did end up adding an exception, but should almost always be hidden behind a short-circuit. |
anntzer
reviewed
Feb 1, 2017
lib/matplotlib/image.py
Outdated
| return | ||
|
|
||
| # for empty images, there is nothing to draw! | ||
| if any(s == 0 for s in self.get_size()): |
|
It looks good to me. It's a better fix than the one I had :) |
QuLogic
reviewed
Feb 6, 2017
lib/matplotlib/image.py
Outdated
| @@ -488,7 +488,7 @@ def draw(self, renderer, *args, **kwargs): | |||
| return | |||
|
|
|||
| # for empty images, there is nothing to draw! | |||
| if any(s == 0 for s in self.get_size()): | |||
| if self.get_arrayy().size == 0: | |||
cdefa0c to
babdf73
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not bother trying to render Images which have zero-dimension in any
direction. Simply return from the
drawmethod earlycloses #7886