Fixed a small mistake in matplotlibrc.template #8042
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
could you double-check that the same mistake wasn't made in other style sheets? |
|
Well I guess that's evidence that changing the base branch can do weird things. |
|
This mistake is made in all branches! I first noticed it on the v2.0.0-doc branch, but afterwards saw it's also on the master. So I changed the branch and all of a sudden, all checks failed 👎 |
|
I switched back to v2.0.0-doc (which will eventually get merged into master), and have closed/opened the PR to see if Travis works again. |
dstansby
approved these changes
Feb 8, 2017
|
@rebot Thanks! I think this is your first contribution to Matplotlib 🎉 Hopefully we will hear from you again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.