DOC: add SOURCELINK_SUFFIX for compatibility with Sphinx 1.5 #8086
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With Sphinx 1.5, this is needed by searchtools.js to display the source snippets (see sphinx-doc/sphinx#2454). With earlier Sphinx versions, this is a no-op because the undefined variable will evaluate to an empty string.
|
wow, that is an annoying change on the behalf of sphinx… It should be taken care of out of the box. |
NelleV
approved these changes
Feb 16, 2017
tacaswell
added a commit
that referenced
this pull request
Feb 17, 2017
DOC: add SOURCELINK_SUFFIX for compatibility with Sphinx 1.5
|
Thanks, backported to v2.0.0-doc as 1cce7d3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With Sphinx 1.5, this is needed by
searchtools.jsto display the source snippets (see sphinx-doc/sphinx#2454, and especially sphinx-doc/sphinx@71dd8bfbf).With earlier Sphinx versions, this is a no-op because the undefined variable will evaluate to an empty string.