Remove example of matrix of size (12, 12) and (64, 64) #8094
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anntzer
reviewed
Feb 17, 2017
| @@ -10,17 +10,7 @@ def samplemat(dims): | |||
| aa[i, i] = i | |||
There was a problem hiding this comment.
Could be rewritten as np.fill_diagonal(aa, range(min(dims))).
There was a problem hiding this comment.
I think the current version is much more readable, which is important for an example.
anntzer
requested changes
Feb 18, 2017
examples/pylab_examples/matshow.py
Outdated
| # Display a random matrix with a specified figure number and a grayscale | ||
| # colormap | ||
| plt.matshow(np.random.rand(64, 64), fignum=100, cmap=plt.cm.gray) | ||
| # Display matrix |
There was a problem hiding this comment.
two spaces, and trailing whitespace.
There was a problem hiding this comment.
Should I remove spaces ?
There was a problem hiding this comment.
one before "matrix" and whatever is after.
|
@anntzer I find your review confusing, you asked for changes with the comment 'LGTM' ;) |
|
I noticed the spaces issue afterwards and forgot to edit the main message :-) |
anntzer
approved these changes
Feb 18, 2017
16 tasks
dstansby
added a commit
that referenced
this pull request
Feb 18, 2017
Remove example of matrix of size (12, 12) and (64, 64)
|
Backported to 2.0.x via 35996ce |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs #7956 Only keep middle plots
Remove first and third example and keep second one.