If path clipping introduces MOVETO operations, change final CLOSEPOLY to LINETO #817
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me. Thanks for finding this. Do you agree it's ready to merge? |
|
I think it is. It passes all tests except for some knownfails. |
jkseppan
added a commit
that referenced
this pull request
Apr 13, 2012
If path clipping introduces MOVETO operations, change final CLOSEPOLY to LINETO
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is for issue #804: logarithmic histograms look wrong in pdf and svg, because clipping negative values introduces MOVETO operations so CLOSEPOLY draws a line to an intermediate node instead of the intended first node. Requesting review from @mdboom.