add gitter link in README #8190
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phobson
requested changes
Mar 4, 2017
README.rst
Outdated
| The first is a good starting point for general questions and discussions. | ||
|
|
||
|
|
||
|
|
||
| .. image:: https://badges.gitter.im/Join%20Chat.svg |
There was a problem hiding this comment.
Could you add a sentence that explains that gitter is for coordinating development and asking questions directly related to contributing to matplotlib?
phobson
approved these changes
Mar 4, 2017
QuLogic
reviewed
Mar 4, 2017
README.rst
Outdated
|
|
||
|
|
||
| The gitter is for coordinating development and asking questions directly related to contributing to matplotlib. |
There was a problem hiding this comment.
"The gitter chat room" or just "Gitter", not "The gitter".
README.rst
Outdated
| The first is a good starting point for general questions and discussions. | ||
|
|
||
| .. image:: https://badges.gitter.im/Join%20Chat.svg |
There was a problem hiding this comment.
I don't think we should repeat the image here; just have some text (like the alt text) pointing to the chat room.
dstansby
approved these changes
Mar 6, 2017
|
Thanks @patniharshit ! |
|
Is there any point backporting this since it only appears on github? |
|
I think this corrects something that was already backported, but i don't feel super-strongly about it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs #8186