Thanks to visit codestin.com
Credit goes to github.com

Skip to content

DOC: Clean up equal-aspect example #8258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 23, 2017
Merged

DOC: Clean up equal-aspect example #8258

merged 1 commit into from
Mar 23, 2017

Conversation

dstansby
Copy link
Member

Part of #7956

@tacaswell
Copy link
Member 

/home/travis/build/matplotlib/matplotlib/doc/faq/howto_faq.rst:356: WARNING: undefined label: pylab_examples-equal_aspect_ratio (if the link has no caption the label must precede a section header)

Moving the example broke an internal link.

@tacaswell tacaswell added this to the 2.0.1 (next bug fix release) milestone Mar 10, 2017
@NelleV
Copy link
Member

NelleV commented Mar 10, 2017

Apart from the broken link, it looks good to me!

@NelleV NelleV added the MEP: MEP12 gallery and examples improvements label Mar 11, 2017
@NelleV
Copy link
Member

NelleV commented Mar 11, 2017 •
edited
Loading

Actually, while you are at it, do you mind adding the prefix plot to the filename?

@dstansby
Copy link
Member Author

Actually, while you are at it, do you mind adding the prefix plot to the filename?

I'm confused as to what that means...

@NelleV
Copy link
Member

NelleV commented Mar 13, 2017

Renaming the files as plot_something.py

@dstansby
Clean equal_aspect_ratio example
f6e2784 
Move equal_aspect_ratio example

Fix broken faq link

Add plot_ prefix
@dstansby
Copy link
Member Author

👍 rebased and squashed

@NelleV NelleV changed the title [DOC] Clean up equal-aspect example [MRG+1] [DOC] Clean up equal-aspect example Mar 17, 2017
NelleV
NelleV approved these changes Mar 17, 2017
View reviewed changes
Copy link
Member

@NelleV NelleV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@QuLogic
Copy link
Member

QuLogic commented Mar 17, 2017

@tacaswell tacaswell added this to the 2.0.1 (next bug fix release) milestone 7 days ago

Do you really want this in 2.0.1? While many doc changes are generally fine, I think anything that moves an example is not a good idea to backport.

@QuLogic QuLogic requested a review from tacaswell March 19, 2017 20:53
@phobson phobson merged commit 16b4ce4 into matplotlib:master Mar 23, 2017
@phobson phobson changed the title [MRG+1] [DOC] Clean up equal-aspect example DOC: Clean up equal-aspect example Mar 23, 2017
@QuLogic QuLogic modified the milestones: 2.1 (next point release), 2.0.1 (next bug fix release) Mar 23, 2017
@dstansby dstansby deleted the aspect-example branch April 2, 2017 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NelleV NelleV NelleV approved these changes

@phobson phobson phobson approved these changes

@tacaswell tacaswell Awaiting requested review from tacaswell

Assignees
No one assigned
Labels
Documentation MEP: MEP12 gallery and examples improvements
Projects
None yet
Milestone
v2.1
Development

Successfully merging this pull request may close these issues.
5 participants
@dstansby @tacaswell @NelleV @QuLogic @phobson