TST: fail on missing baseline file #8262
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You probably meant to raise that exception. But I wonder whether we even need to bother doing the copy -- why can't we just compare with the image in its original folder (and fail on access if the image is not present)? |
b5e777e to
a4c309e
Compare
|
Force-pushed a fix to raise. That is an interesting question, the copying goes back to a5729a5 with the comment "testing bugfix: don't save test results to site-packages". One nice thing about copying the files is that it puts them (along with the results) next to each other with slightly different names which is something that |
anntzer
reviewed
Mar 10, 2017
anntzer
approved these changes
Mar 10, 2017
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change from a fail to knownfail on missing file come in via 3f3991a which I apparently did not review carefully enough, sorry.