-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Fix testing with tests.py on Py3.6. #8281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -14,15 +14,16 @@ | |
|
||
if __name__ == '__main__': | ||
|
||
import dateutil.parser | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It's good to get rid of these in Matplotlib itself, but it's hacks like these that make me a bit wary to keep this test setup around. Maybe when we figure out the cron jobs, we can run this on a nightly build or something. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. FWIW I think this test really belongs in something like pycodestyle. |
||
try: | ||
import setuptools | ||
except ImportError: | ||
pass | ||
|
||
# The warnings need to be before any of matplotlib imports, but after | ||
# setuptools (if present) which has syntax error with the warnings enabled. | ||
# Filtering by module does not work as this will be raised by Python itself | ||
# so `module=matplotlib.*` is out of questions. | ||
# dateutil.parser and setuptools (if present) which has syntax error with | ||
# the warnings enabled. Filtering by module does not work as this will be | ||
# raised by Python itself so `module=matplotlib.*` is out of question. | ||
|
||
import warnings | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this warning not come out of singular dates anymore?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope (that's why the tests pass :-)).