In ginput(), don't call show() if we can't. #8305
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ginput
works even for figures that are not created byplt.figure()
(and friends -- typically, that means we're embedding matplotlib in a
GUI app)... except that
ginput
tries to callfig.show()
to raise thefigure, which would fail.
Instead, only call
fig.show
if the figure has a manager (i.e., wascreated by
plt.figure
).Example (click once to start point selection, then make further clicks
as in a normal
ginput
call):