Fix % formatting and Transform equality. #8399
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use `.format(key)` instead of `% key` formatting which fails when `key` is a tuple (one could also use `% (key,)` but we may as well use the more modern option). The `Transform` class doesn't need to override `__eq__` as user-defined classes default to using identity for equality. This also avoids having to add a `__hash__` to these classes to make them hashable (by default, user-defined classes are hashable, but become unhashable (in Py3) if they define a `__eq__` without defining a `__hash__`). A more complete PR should define `__hash__` for all `Transform` subclasses too.
dstansby
approved these changes
Apr 12, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
.format(key)instead of% keyformatting which fails whenkeyis a tuple (one could also use
% (key,)but we may as well use themore modern option).
The
Transformclass doesn't need to override__eq__as user-definedclasses default to using identity for equality. This also avoids having
to add a
__hash__to these classes to make them hashable (by default,user-defined classes are hashable, but become unhashable (in Py3) if
they define a
__eq__without defining a__hash__). A more completePR should define
__hash__for allTransformsubclasses too.Partial fix for #8395 (a full fix needs to restore hashability of most Transform subclasses).