Let imshow handle float128 data. #8447
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There are too many windows failures to be transient. |
|
I think I got it right this time. |
tacaswell
reviewed
Apr 13, 2017
| if (self._A.ndim not in (2, 3) or | ||
| (self._A.ndim == 3 and self._A.shape[-1] not in (3, 4))): | ||
| if not (self._A.ndim == 2 | ||
| or self._A.ndim == 3 and self._A.shape[-1] in [3, 4]): |
There was a problem hiding this comment.
I think that the not should not have been dropped?
I am partial towards leaving in (), even if they are not strictly needed when they help clarity.
There was a problem hiding this comment.
the boolean structure looks correct to me
i think the newline already helps with priority
There was a problem hiding this comment.
Ah, I missed the leading not when I read this before 🐑
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The important parts are passing "same_kind" to can_cast (so that float128 is considered castable to float64) and converting float128 (longdouble for windows compat) back to float32 after normalization (as Agg doesn't handle float128). The rest is just small esthetic fixes.
xref #8445.