Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Remove useless, confusing check in hist(). #8492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 16, 2017
Merged

Remove useless, confusing check in hist(). #8492

merged 1 commit into from
Apr 16, 2017

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Apr 15, 2017

_saved_bounds is not used anywhere. It was introduced in c8af84a and even then was only used for numpy<=1.2.

Closes #7754.

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is PEP 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/whats_new.rst if major new feature
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzer
Remove useless, confusing check in hist().
f3294dd 
_saved_bounds is not used anywhere.  It was introduced in
c8af84a and even then was only used for
numpy<=1.2.
QuLogic
QuLogic approved these changes Apr 15, 2017
View reviewed changes
Copy link
Member

@QuLogic QuLogic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't even know what the "same" reason is.

@QuLogic QuLogic changed the title Remove useless, confusing check in hist(). [MRG+1] Remove useless, confusing check in hist(). Apr 15, 2017
@tacaswell tacaswell merged commit 4efca09 into matplotlib:master Apr 16, 2017
@QuLogic QuLogic changed the title [MRG+1] Remove useless, confusing check in hist(). Remove useless, confusing check in hist(). Apr 16, 2017
@QuLogic QuLogic modified the milestones: 2.0.1 (next bug fix release), 2.1 (next point release) Apr 17, 2017
@anntzer anntzer deleted the remove-useless-check-in-hist branch December 26, 2017 01:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QuLogic QuLogic QuLogic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.1
Development

Successfully merging this pull request may close these issues.

Forgotten restore bounds?
3 participants
@anntzer @QuLogic @tacaswell