Discourage omitting backend in matplotlibrc #8518
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This can lead to unexpected behavior as matplotlib defaults to a non-interactive backend.
tacaswell
reviewed
Apr 20, 2017
| @@ -35,6 +35,9 @@ | |||
| # You can also deploy your own backend outside of matplotlib by | |||
| # referring to the module name (which must be in the PYTHONPATH) as | |||
| # 'module://my_backend'. | |||
| # | |||
| # If you omit this parameter, it will always default to "Agg", which is a | |||
There was a problem hiding this comment.
I do not think this is not quite true, the value of $TEMPLATE_BACKEND is set at build time based on what it finds. Some of the wheels we have released do in fact default to Agg (because they are built in very clean environments).
There was a problem hiding this comment.
Here is what I observed on my particular installation:
- No user config file:
Qt5Agg(the same backend listed indata/matplotlibrc. - With user config file but
backendis not set in that file:Agg. Naively I would have expectedQt5Aggtoo but it seems that is not the case. This is what prompted this PR.
tacaswell
approved these changes
Apr 20, 2017
|
The AppVeyor failure here is not spurious; this change broke it because the patch for building conda packages no longer applies to the template file. |
|
Oh shoot. Sorry. I missed that :/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Remind users who want to customize their
matplotlibrcto set the backend, or else unexpected behavior can occur as matplotlib defaults to a non-interactive backend.PR Checklist