Mpl toolkit fix for zoomed_inset_axes #8601
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QuLogic
reviewed
May 11, 2017
lib/matplotlib/tests/test_axes.py
Outdated
| fig, ax = plt.subplots() | ||
| ax.plot([1, 2, 3], [1, 2, 3]) | ||
| ax.axis([1, 3, 1, 3]) | ||
| from mpl_toolkits.axes_grid1.inset_locator import zoomed_inset_axes |
There was a problem hiding this comment.
If it uses mpl_toolkits, it doesn't belong in this file. It should go somewhere in lib/mpl_toolkits/tests.
Delete inset_locator.py Add files via upload Delete test_axes.py Add files via upload Update test_axes.py Delete test_axes.py Add files via upload Add files via upload Update test_axes.py move test into appropriate folder remove unneccessary import from test
|
As with last time, the appveyor build fails, but i can't reproduce. If someone could rebuild to see if it still fails, i'll be thankful |
QuLogic
reviewed
May 14, 2017
| fig, ax = plt.subplots() | ||
| ax.plot([1, 2, 3], [1, 2, 3]) | ||
| ax.axis([1, 3, 1, 3]) | ||
| from mpl_toolkits.axes_grid1.inset_locator import zoomed_inset_axes |
There was a problem hiding this comment.
This is already imported at the top of the file.
|
fixed test case by @QuLogic comment and squashed commit as requested by @tacaswell. |
|
Probably should have corrected the commit message a bit, though... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
A small fix for #8589. Test cases provided.
PR Checklist