Fix a number of minor local bugs #8608
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The list comprehension variable was captured and would always be the last element of the font family list. See https://lgtm.com/projects/g/matplotlib/matplotlib/snapshot/04c252c6b155aba6a68b28f10fc8c84a784ff2c2/files/lib/matplotlib/texmanager.py#L203
print_exc only takes two optional arguments, the exception is implicit (https://docs.python.org/2/library/traceback.html). See https://lgtm.com/projects/g/matplotlib/matplotlib/snapshot/04c252c6b155aba6a68b28f10fc8c84a784ff2c2/files/lib/matplotlib/backends/backend_wx.py#x9c9bbb754faeabae%3A1
QuLogic
approved these changes
May 11, 2017
|
That is a pretty nifty service! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I was browsing matplotlib on www.lgtm.com, and noticed a number of alerts (https://lgtm.com/projects/g/matplotlib/matplotlib/alerts/). Some of them were fairly clear-cut, and I saw that I could fix them immediately, hence this PR. Others would require someone with more knowledge of the code to triage.
You can also turn on PR integration to help avoiding introducing more of these kinds of errors: https://lgtm.com/projects/g/matplotlib/matplotlib/ci/
By the way, matplotlib has been incredibly useful in my work, love the project! I hope this can help a little.