BUG: Correct invocation of expand_dims
#8610
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`alpha` is 2d, yet here it was requested to insert a fourth dimension. This rightly produces an error in numpy 1.13.0rc1, although we might soften this to a deprecation warning
dopplershift
approved these changes
May 11, 2017
|
Indeed, although I think that was accidental, rather than by design. I've filed an issue at numpy/numpy#9100 about restoring the old behaviour to keep old matplotlib working |
dstansby
approved these changes
May 12, 2017
|
This is now fixed upstream in numpy to give a deprecation warning |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
alphais 2d, yet here it was requested to insert a fourth (not third) dimension.This rightly produces an error in numpy 1.13.0rc1, although the final release might soften this to a deprecation warning to prevent breaking old version of matplotlib