Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Remove unused resolution kwarg to PolarAxes #8643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 23, 2017
Merged

Remove unused resolution kwarg to PolarAxes #8643

merged 3 commits into from
May 23, 2017

Conversation

patniharshit
Copy link
Contributor

@patniharshit patniharshit commented May 19, 2017 •
edited
Loading

PR Summary

Remove unused resolution kwarg to PolarAxes
refs #8629

PR Checklist

  • Has Pytest style unit tests
  • Code is PEP 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/whats_new.rst if major new feature
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@tacaswell
Copy link
Member

Can you add a note in the API changes docs? I think if a user does pass in resolution in will now raise instead of warning so we need to note that.

@tacaswell tacaswell added this to the 2.1 (next point release) milestone May 19, 2017
@patniharshit
Copy link
Contributor Author

Wasn't sure where to put note for api change, let me know the right place to to put it if its not.

QuLogic
QuLogic reviewed May 20, 2017
View reviewed changes
doc/api/api_changes/2017-05-19-resolution_polar_axes.rst Outdated

The kwarg `resolution` of `matplotlib.projections.polar.PolarAxes` has been
removed. It has triggered a warning of being with no effect which acted as the
deprecation warning as well.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Second half of this sentence is kind of redundant. Should mention since which version it's been deprecated.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Version added.

tacaswell
tacaswell approved these changes May 22, 2017
View reviewed changes
Copy link
Member

@tacaswell tacaswell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

windows failure looks transient.

@QuLogic QuLogic merged commit 2a631da into matplotlib:master May 23, 2017
@patniharshit patniharshit deleted the resolution branch May 23, 2017 06:24
@patniharshit patniharshit mentioned this pull request May 29, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QuLogic QuLogic QuLogic left review comments

@tacaswell tacaswell tacaswell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.1
Development

Successfully merging this pull request may close these issues.
3 participants
@patniharshit @tacaswell @QuLogic