Add basic testing of wxagg backend. #8676
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QuLogic
reviewed
May 28, 2017
.travis.yml
Outdated
| # runtime, so an actual import is a better check). | ||
| pip install pyqt5 && | ||
| python -c 'import PyQt5.QtCore' || | ||
| true |
There was a problem hiding this comment.
Can you make this something like && echo "PyQt5 is available" || echo "PyQt5 is not available" (and similar below)? I know no output == okay, but it's nice to see confirmation.
|
Oh, duh, it's in the condition right before. Can you mark them as skipped instead of passing an empty parametrization? Having a different number of total tests is a bit confusing. |
wxPython provides Trusty wheels, so use them.
|
addressed both issues |
QuLogic
approved these changes
May 28, 2017
dstansby
approved these changes
May 29, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
wxPython provides Trusty wheels, so use them.
(followup to #8660)